Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch mode for grit patterns test #51

Open
morgante opened this issue Mar 22, 2024 · 9 comments · May be fixed by #298
Open

Watch mode for grit patterns test #51

morgante opened this issue Mar 22, 2024 · 9 comments · May be fixed by #298
Labels
💎 Bounty

Comments

@morgante
Copy link
Contributor

morgante commented Mar 22, 2024 •
edited

We would like to have a watch mode for grit patterns test --watch.

Watch mode should be similar to other testing/CLI tools that offer a watch mode: when files change, re-run tests.

Acceptance criteria

  • Watch mode should watch for file changes to any patterns in the .grit directory and automatically re-run those tests
  • If a file changes, only the affected patterns should be re-run. Ex. if I edit this file then only that pattern test should re-run.
  • You will also need to account for pattern dependencies. Ex. if https://github.com/getgrit/stdlib/blob/main/.grit/patterns/js/imports.grit is edited then any patterns which use the ensure_import_from pattern should be re-run. Utilities like this can be leveraged for walking the call graph
  • At least 2 tests should be included, including ideally at least one integration test of the final binary like we do here.
@morgante
Copy link
Contributor Author

/bounty $250

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Mar 22, 2024 •
edited

💎 $250 bounty • Grit

Steps to solve:

  1. Start working: Comment /attempt #51 with your implementation plan
  2. Submit work: Create a pull request including /claim #51 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Additional opportunities:

Thank you for contributing to getgrit/gritql!

Add a bounty • Share on socials

Attempt Started (GMT+0) Solution
🟢 @el-buku Mar 22, 2024, 12:42:53 PM WIP
🟢 @Sambit003 Mar 25, 2024, 9:57:36 AM WIP
🟢 @Ashu999 Apr 24, 2024, 6:18:34 AM #298

@el-buku
Copy link

el-buku commented Mar 22, 2024 •
edited by algora-pbc bot

/attempt 51

Options

@webbdays
Copy link

@el-buku
any progress.
still on this?

@el-buku
Copy link

el-buku commented Mar 22, 2024 via email

@Sambit003
Copy link

Sambit003 commented Mar 25, 2024 •
edited by algora-pbc bot

/attempt #51

Options

@vivasvan1
Copy link

@Sambit003 @el-buku
Hi there fellas,

Are you working on this?
If yes, let me know if you interested in working togather.
If no, I would like to attempt it.

Hope u have a nice day.

@Ashu999
Copy link

Ashu999 commented Apr 24, 2024 •
edited by algora-pbc bot

/attempt #51

Options

@Ashu999 Ashu999 linked a pull request May 1, 2024 that will close this issue
Open
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented May 1, 2024 •
edited

💡 @Ashu999 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Bounty
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: watch mode for patterns test Ashu999/gritql
6 participants
@morgante @vivasvan1 @Ashu999 @webbdays @el-buku @Sambit003