Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: add warning for missing recommended php modules #37

Open
Rotzbua opened this issue Aug 8, 2022 · 0 comments · May be fixed by #38
Open

Suggestion: add warning for missing recommended php modules #37

Rotzbua opened this issue Aug 8, 2022 · 0 comments · May be fixed by #38

Comments

@Rotzbua
Copy link
Contributor

Rotzbua commented Aug 8, 2022 •
edited

The PHPModules check only have success or error as result. Grav uses for some modules polyfills which impacts performance and abilities negative.

I think it would be useful to show a warning if the polyfill implementation is used and not a native module.

Currently polyfilled optional modules are:

  • mbstring
  • iconv

Optional are:

  • intl
  • xdebug

Furthermore, the checks of the cache modules should be added:

  • redis
  • memcache
  • [...]

Disclaimer: List might not be correct.
@Rotzbua Rotzbua linked a pull request Aug 10, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extend php module check Rotzbua/grav-plugin-problems
1 participant
@Rotzbua