Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependance on vulnerable version of request #16

Closed
aliciagyt opened this issue Apr 1, 2024 · 4 comments · May be fixed by #19
Closed

Dependance on vulnerable version of request #16

aliciagyt opened this issue Apr 1, 2024 · 4 comments · May be fixed by #19

Comments

@aliciagyt
Copy link

I currently use version 2.0.0-beta.4 and when I run npm audit fix, it signals me that I have 2 moderate vulnerabilities, one on request and one on tough-cookie, and that fixing them will install brevo@1.0.1 because brevo >=2.0.0-beta.2 depends on vulnerable versions of request.
request being deprecated anyway (source), do you plan to switch to axios or another library soon? Thanks !

@shubhamUpadhyayInBlue
Copy link
Collaborator

Hi @aliciagyt
Here is a new version https://www.npmjs.com/package/@getbrevo/brevo/v/2.1.1 which has many critical and high security vulnerabilites issues fixed. Kindly check this out.
Thanks.

@milo-stadion
Copy link

@shubhamUpadhyayInBlue I've just updated to 2.1.1 and it still contains the vulnerable version of the request package.

This package has been deprecated since 2020, so you should be looking to move to something new as a priority.

You can see more information about the deprecation here

You can find information about the vulnerability here

CleanShot 2024-05-01 at 09 28 11@2x

@shubhamUpadhyayInBlue
Copy link
Collaborator

shubhamUpadhyayInBlue commented May 1, 2024

Hi @milo-stadion
Yes, I agree with you that request module should not be used since it's deprecated. But, since these SDKs are generated using the Openapi generator it's not very straight forward to stop the usage of existing dependency package and keep the SDK backward compatible for all the APIs we support.

It is the same with the remaining Medium level vulnerabilities. However, I have bumped up the versions of other dependencies to fix the Critical and High level vulnerabilities.

However, we will discuss it to come out with a solution to this problem soon.

Thanks.

@milo-stadion
Copy link

Thanks @shubhamUpadhyayInBlue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants