Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument about tests location #7

Open
DominicF96 opened this issue Mar 30, 2022 · 0 comments
Open

Argument about tests location #7

DominicF96 opened this issue Mar 30, 2022 · 0 comments

Comments

@DominicF96
Copy link

DominicF96 commented Mar 30, 2022

Hello !

I hope this kind of issue is welcome. 馃槄

I've inspected the project structure you suggest and found that it works really well for me.
I used to regroup what goes in controllers and services and always ended up with hardly reusable code.
With your approach, I can now reuse code much more easily so thanks for that! 馃コ

One thing I would argue about though is the location of the tests.

While it's nice to isolate tests so that they don't 'polute' your source code, having them in
a different directory feels weird for various reasons;

  • It puts them aside and not part of the project, therefore developers would be less inclined to write them
  • It goes against the module mentality (which makes it less reusable)
  • It makes them harder to find when working on specific files

Would love to hear your opinion on that, thanks again for this structure template ! 馃槃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant