Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic in RegionAssembly reproducibly #1127

Open
frehberg opened this issue Dec 21, 2023 · 4 comments
Open

Panic in RegionAssembly reproducibly #1127

frehberg opened this issue Dec 21, 2023 · 4 comments

Comments

@frehberg
Copy link

frehberg commented Dec 21, 2023

Occasionally (1:8) I observe a panic condition. I managed to print out the data of RegionAssembly causing the panic, and using this data to create a regression test (see PR)

Code with regresssion test assembling 3668 segments/lines #1126

The panic occures in the the check in file assembly.rs

            debug_assert!(num_segments % 2 == 0, "assembly segments must be eulierian");

The execution path leading to this point of the RegionAssembly occures in the context of bop.sweep() in the following code

impl<T: GeoFloat> BooleanOps for MultiPolygon<T> {
    type Scalar = T;

    fn boolean_op(&self, other: &Self, op: OpType) -> MultiPolygon<Self::Scalar> {
        let spec = BoolOp::from(op);
        let mut bop = Proc::new(spec, self.coords_count() + other.coords_count());
        bop.add_multi_polygon(self, 0);
        bop.add_multi_polygon(other, 1);
        bop.sweep()
    }

Appreciating any hint why this crash occures and how to avoid the panic crash

Screenshot from 2023-12-21 11-30-58

@urschrei
Copy link
Member

#1102, #1103, and #1104 may be related here.

@frehberg frehberg changed the title Panic in RegionAssembly occasionally Panic in RegionAssembly reproducibly Jan 8, 2024
@frehberg
Copy link
Author

frehberg commented Jan 8, 2024

is the code of RegionAssembly crashing due to a bug in the algorithm, or due to bad input parameters? In case of the latter, how to prevent this?

@urschrei
Copy link
Member

urschrei commented Jan 8, 2024

It's crashing due to a bug, and a fix is unlikely in the short term.

@frehberg
Copy link
Author

frehberg commented Jan 9, 2024

hopefully this test #1126 can help you to reproduce the issue and fix the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants