Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests to accommodate multiple node versions #25

Open
georgemandis opened this issue Jun 10, 2022 · 0 comments
Open

Fix tests to accommodate multiple node versions #25

georgemandis opened this issue Jun 10, 2022 · 0 comments

Comments

@georgemandis
Copy link
Owner

Currently the following examples are failing:

  • 41
  • 45
  • 46

Those should be examined to make sure there isn’t in fact something broken with them, but for 41 and 46 at least the issues lies in globalThis not existing in the Node version the GH action runs in (See issue #14).

It’ll be cumbersome to fix, but I think moving each file into its own folder with a corresponding .nvmrc file might be the way forward (Or maybe use asdf if I’m feeling…fun?).

Once I do that and the template is there is shouldn’t be that hard to maintain going forward.

While I’m doing this I might want to reexamine the test suite and see if I can better accommodate more adventurous solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant