Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rasterio dependency is missing in requirements.txt file #136

Open
krishnaglodha opened this issue Jun 22, 2023 · 3 comments
Open

rasterio dependency is missing in requirements.txt file #136

krishnaglodha opened this issue Jun 22, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@krishnaglodha
Copy link
Member

I am trying to run jupyter notebook locally, but in geopython-workshop/workshop/jupyter/requirements.txt rasterio is missing

@justb4
Copy link
Member

justb4 commented Jun 22, 2023

I see, but I am hesitant to change geopython-workshop/workshop/jupyter/requirements.txt at this point in time.
This file is also used in the Dockerfile and -build where rasterio is installed as a Debian (python3-rasterio) package. There could be potential dependency conflicts, resulting in a failing Notebook. Everything has to be tested again, begin to end. We have a stable situation now. Maybe rasterio was even taken out of requirements.txt for that reason. That file is tuned for the Ubuntu env and .deb installs in the Dockerfile.

At the workshop we will use Docker. Custom install is at own risk. Will need its own requirements.txt , install guide, and base deps like GDAL and Proj. Maybe Conda Forge works better for that case. That would be a useful addition.

@justb4 justb4 added the enhancement New feature or request label Jun 22, 2023
@krishnaglodha
Copy link
Member Author

@justb4 got it! Thanks :D

@ldesousa
Copy link

I agree it is a bit too late to try this kind of change. The notebook in Section 5 is working fine as it is.

We can give it a try later during the code sprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants