Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete integration experiment run scripts #3439

Open
dannosliwcd opened this issue May 7, 2024 · 0 comments
Open

Remove obsolete integration experiment run scripts #3439

dannosliwcd opened this issue May 7, 2024 · 0 comments
Labels
tech debt Refactoring and maintenance tasks

Comments

@dannosliwcd
Copy link
Contributor

Since #2638, we have a single run_experiment.py script to launch all integration app-experiment combinations. We still have several now-obsolete run scripts named run_<experiment>_<app>.py which can be deleted.

In order to delete the obsolete scripts, both the app and experiment need to be listed by run_experiment.py apps and run_experiment.py experiments, respectively.

If an app or experiment is not acknowledged by the launcher, then ensure that:

  • Missing apps have a create_appconf(Machine, argv) factory function
  • Experiments have launch(app_conf, args, experiment_cli_args)
  • Both apps and experiments support setup_run_args(parser)

Also check whether any integration tests directly invoke the old interface. Update them to use the new interface.

@dannosliwcd dannosliwcd added the tech debt Refactoring and maintenance tasks label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Refactoring and maintenance tasks
Projects
None yet
Development

No branches or pull requests

1 participant