Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD/RLS: to include spatialite in wheels or not to? #378

Open
theroggy opened this issue Mar 30, 2024 · 1 comment
Open

BLD/RLS: to include spatialite in wheels or not to? #378

theroggy opened this issue Mar 30, 2024 · 1 comment

Comments

@theroggy
Copy link
Member

theroggy commented Mar 30, 2024

As mentioned here, geopandas/geopandas#3223, think through whether it it would be better to include it or not...

@theroggy theroggy changed the title To include spatialite in wheels or not to? BLD/RLS: To include spatialite in wheels or not to? Mar 30, 2024
@theroggy theroggy changed the title BLD/RLS: To include spatialite in wheels or not to? BLD/RLS: to include spatialite in wheels or not to? Mar 30, 2024
@jorisvandenbossche
Copy link
Member

Moving my comment from #330 (comment) here:

At this point the wheel build still doesn't include libspatialite support, i.e. the libspatialite feature is not enabled in the vcpkg GDAL build.

Looking at it again, it seems we could do that . @brendan-ward you commented about that in #86 (comment):

Not sure if this matters, but noting for the record that our vcpkg build does not include libspatialite (we don't enable that as an add-on feature); it is LGPL licensed, which likely has license implications for the wheels we create. I believe Fiona also does not build against libspatialite.

In #161 I first added libspatialite feature, but then removed it again before the PR was merged, and I don't directly see any discussion or explanation that explains why I did that .. But there is a bit of discussion later at #161 (comment), which again mentions that fiona also doesn't have this.

Now, I don't think licensing is a problem, given that GEOS also uses LGPL, and we do already include that in the wheels.

Given that vcpkg has the feature to build GDAL with libspatialite, we should probably just try that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants