Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autodiff fails on svd in pre_shape.py #8

Open
vontycowicz opened this issue Mar 28, 2022 · 1 comment
Open

autodiff fails on svd in pre_shape.py #8

vontycowicz opened this issue Mar 28, 2022 · 1 comment
Assignees

Comments

@vontycowicz
Copy link
Contributor

Dear geomstats team,

we are trying to perform geodesic regression in Kendall shape space but encountered the issue that the current implementation is not compatible with autodiff functionality.
In particular, the align method in geomstats/geometry/pre_shape.py employs singular value decomposition for which autodiff fails if a full set of left/right singular vectors are requested.
However, providing the flag 'full_matrices=False' avoids this pitfall and should yield the same alignment.

We added the flag and, indeed, are now able to run regression.
We will submit the modified pre_shape.py along with our project s.t. it does not rely on short notice updates of geomstats.

Best regards,
Christoph

@ninamiolane
Copy link
Contributor

Thank you very much for the heads-up, and for finding this workaround. Looking forward to your submission!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants