Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow removal of holes in polygons while maintaining the minimum vertex count of the geometry #1475

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Tobikblom
Copy link

@Tobikblom Tobikblom commented Apr 1, 2024

Fixes #1474.

Also, please verify that parentPath[parentPath.length - 1] > 0 correctly checks if the vertex is part of a hole when the layer is an instance of L.Polygon.

Copy link
Collaborator

@Falke-Design Falke-Design left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this PR. Can you please add a test as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling "removeLayerBelowMinVertexCount" prevents removal of holes in polygon
2 participants