Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vq constants and scaling #70

Open
markyoder opened this issue Mar 25, 2015 · 2 comments
Open

vq constants and scaling #70

markyoder opened this issue Mar 25, 2015 · 2 comments

Comments

@markyoder
Copy link
Contributor

this is really a TODO: in the code:

we'll want to talk about constants and scaling. note th eline in RunEvent.cpp:
double rupture_area = pow(10, -3.49+0.91*as.mag);

  1. wrong place for this sort of declaration/assignment
  2. we'll want to talk about scaling constants. in particular, i think this .91 should definitely be 1.0 for area, but not everybody's going to agree with me, and we want to be able to vary this, to do science and stuff.

aka:
double area_factor = -3.5;
double b_area = 1.0;
double b_gr = 1.0; // though, these should probably always be the same, otherwise, N/A != const... or should it?
double rupture_area = pow(10, area_factor + b_area*as.mag)

so, if we're so inclined, we can use this ticket to discuss and make requests for vq_scaling_constants.h, otherwise it will just stand as a "TODO" reminder.

@eheien
Copy link
Contributor

eheien commented Mar 25, 2015

Yes, this is a good idea. Instead of a header, though, I'd make it a parameter so it doesn't need to be recompiled.

@kwschultz
Copy link
Contributor

kwschultz commented May 24, 2016

Current scaling parameters come from Mark Leonard's 2010 paper on scaling.
Search through the VQ source code for "Leonard 2010" to find instances where the constants are used.

This is low-hanging fruit for a newer graduate student to become familiar with the VQ code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants