Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify and extend BM expansion order #234

Open
bobmyhill opened this issue Feb 24, 2016 · 1 comment
Open

Clarify and extend BM expansion order #234

bobmyhill opened this issue Feb 24, 2016 · 1 comment

Comments

@bobmyhill
Copy link
Member

Currently, the code is written for BM 3rd order expansion, with a second or third order expansion for the shear modulus. This is not obvious in the user code (although it is in the documentation)

Would it be better to define two parameters, and then have two separate flags: self.shear_order and self.bulk_order, to clarify what is actually being done in the calculations?

@bobmyhill
Copy link
Member Author

The easiest way to do this would be to rewrite the PVK expressions in BM up to fourth order, then have a flag which sets

  • K'' = -1./K * (K'(K' - 7.) +143/9) for BM3 and BM2
  • K' = 4 for BM2

Different functions would be more efficient though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant