Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should there be. top-level CMakeLists.txt? #63

Open
markyoder opened this issue Jul 1, 2020 · 1 comment
Open

Should there be. top-level CMakeLists.txt? #63

markyoder opened this issue Jul 1, 2020 · 1 comment

Comments

@markyoder
Copy link

markyoder commented Jul 1, 2020

Should there be a top level CMakeLIsts.txt, or should MESHER and SOLVER be compiled separately?

Looking back at this fix:
e9f73ba

seems to indicate that there should be a top-level build. Generally, the build instructions in the documentation are pretty vague. If you can clarify some of the finer points, I can cut a Fork and help with that.

Possibly answering my own question, it looks like, yes, and that this disappearing CMakeLIsts.txt file has been a (probably git promoted problem for a while). It looks like the most recent commit with a top level CMakeLists.txt is: 4e5c7b1a3d5df6fd664e65ad9ab7bef9f2f1f1bd

Is that correct?

... but then I see a later commit where the cmake directory appears to be intentionally removed. I restored both of these from their most recent commits and appear to have compiled the code (still needs a test), but I would certainly appreciate any guidance from the developers. Thanks in advance!

@sstaehler
Copy link
Contributor

Hi @markyoder ,

apologies for the late reply. Correct, cmake was removed deliberately, because we found that it was not beneficial for the relatively easy compilation task we have.

Run
$ copy_templates.sh
in the main directory to create makefiles and then do
$make

Best,

Simon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants