Revert "Improve cmake system" to improve Tester performance #5631
+28
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fbec533.
|
This seem to bring compile times back down @gassmoeller . Not sure why. :-( |
|
The only explanation would be if the compile definitions are actually affected by this change. I thought it would only make a difference for DebugRelease mode, but maybe I was wrong. I can give it a try later this week (comparing the definitions set for the WorldBuilder cmake target). |
|
Note that Jenkins compiles in DebugRelease mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit fbec533 PR #5621
An attempt to fix #5630. Please do not merge.