Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nconst=10 and nfunc=14 hard-coded into class equation_coefficients #491

Open
illorenzo7 opened this issue Nov 30, 2023 · 0 comments
Open

Comments

@illorenzo7
Copy link
Contributor

illorenzo7 commented Nov 30, 2023

This issue concerns the file "reference_tools.py" in the post_processing folder. It hard-codes number of constants and functions in the PDE set to 10 and 14 (the most common) but doesn't allow the possibility that (currently only the constants) these could be different, if the user specifies scalar diffusions.

I think this could be handled going forward by assuming all previously generated equation_coefficients files had nconst=10, nfunc=14 and keep the current logic if version=1. Then change the version to 2 in Fortran, and have the new equation_coefficients files also include the nconst and nfunc integers explicitly, directly after the version number is written, and before the "cset" and "fset" are written. Finally, change the equation_coefficients.py file to have the appropriate reading contingency based on version number 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant