Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings and errors #423

Open
illorenzo7 opened this issue Dec 14, 2022 · 0 comments
Open

Warnings and errors #423

illorenzo7 opened this issue Dec 14, 2022 · 0 comments
Labels
bug errors and messages Essentially: Issues with Rayleigh's print statements, including errors and warnings.

Comments

@illorenzo7
Copy link
Contributor

I don't think the code is consistent in its usage of warnings and errors. I believe a "warning" should occur when the code notices something might be up, and prints a useful message, but keeps running. If there is an "error", the code should exit. Currently lots of "errors" don't lead to exits. It looks like most of these occur in the (relatively new) files:

PDE_Coefficients.F90
and
Generic_Input.F90

I'm not sure of best way forward: Either we make the errors that don't lead to exits warnings, or we force the things listed as errors to exit. It might be worth going through the cases in the above files one by one. I plan to do this for PDE_Coefficients after addressing the custom reference stuff: #419 and #420.

I'm flagging this as a "bug" as well as "errors and messages" because the code isn't running as it should in some cases. That could be a little harsh though...

@illorenzo7 illorenzo7 added bug errors and messages Essentially: Issues with Rayleigh's print statements, including errors and warnings. labels Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug errors and messages Essentially: Issues with Rayleigh's print statements, including errors and warnings.
Projects
None yet
Development

No branches or pull requests

1 participant