Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option sparsesolve is not functional #367

Open
tukss opened this issue Aug 20, 2022 · 0 comments
Open

Option sparsesolve is not functional #367

tukss opened this issue Aug 20, 2022 · 0 comments

Comments

@tukss
Copy link
Contributor

tukss commented Aug 20, 2022

When compiling with the Cray compiler I noticed warnings that we are using the error variable before defining it in the methods LU_DECOMPOSE_MATRICES, LU_SOLVE_SPARSE, and LU_DECOMPOSE_SPARSE. This is true because the actual calls to pardiso are commented. I don't think we would get correct results if sparsesolve is set at the moment, although it's possible that this particular code path is never reached.

Do we need the sparsesolve option? If yes, maybe we should add an #ifdef usepardiso around the calls to pardiso (after uncommenting them, of course) and let the methods abort with an error if the code is compiled without usepardiso. I'm happy to make a PR with these changes, but I'll only do it if we actually need the sparsesolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant