Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output goes to weird places when logfiles are specified because of Write(6,*) #325

Open
illorenzo7 opened this issue Sep 27, 2021 · 0 comments
Labels
errors and messages Essentially: Issues with Rayleigh's print statements, including errors and warnings.

Comments

@illorenzo7
Copy link
Contributor

@feathern

In testing multirun mode, I am noticing that although most output from Rayleigh is handled through

stdout%print()

a fair amount is handled through

Write(6, *)

Normally, this will all go to the same place (terminal screen) so if someone just redirects the screen output, say,

mpiexec 2048 ./rayleigh.opt > logfile

it will be fine. However, if a logfile is specified (which we must do in multirun mode),

stdout % print

will go to the logfile, and

write(6, *)

will go to the "screen" which is likely the parent directory.

Unless I am missing something, it seems like Write(6, *) should never be used in the code, only stdout%print ?

Doing a grep looks like these write(6,*) statements appear 49 times. Happy to make a pull request fixing this (if I haven't missed anything) but it will change quite a few files. Can also wait until version 1.0

@illorenzo7 illorenzo7 added the errors and messages Essentially: Issues with Rayleigh's print statements, including errors and warnings. label Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
errors and messages Essentially: Issues with Rayleigh's print statements, including errors and warnings.
Projects
None yet
Development

No branches or pull requests

1 participant