Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow viewport clipping to be defined separately for x and y directions #237

Open
tuner opened this issue Feb 14, 2024 · 0 comments
Open

Allow viewport clipping to be defined separately for x and y directions #237

tuner opened this issue Feb 14, 2024 · 0 comments
Labels
core Related to the Core package good first issue Good for newcomers Improvement Improve an existing functionality, don't introduce a new feature WebGL Somehow related to WebGL or GPU

Comments

@tuner
Copy link
Member

tuner commented Feb 14, 2024 •
edited

For example, when the viewport is zoomed only along the x axis, there's generally no need to clip the y axis.

Unnecessary clipping causes headache when, for instance, rect marks with strokes touch the viewport edges – a half of the stroke is clipped away:

image

... or if no yOffset of -0.5 is applied:

image
@tuner tuner added good first issue Good for newcomers Improvement Improve an existing functionality, don't introduce a new feature core Related to the Core package WebGL Somehow related to WebGL or GPU labels Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Related to the Core package good first issue Good for newcomers Improvement Improve an existing functionality, don't introduce a new feature WebGL Somehow related to WebGL or GPU
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tuner