Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ldso: add support for R_<arch>_NONE relocations #5209

Open
ssumpf opened this issue May 7, 2024 · 1 comment
Open

ldso: add support for R_<arch>_NONE relocations #5209

ssumpf opened this issue May 7, 2024 · 1 comment
Labels
feature fixed

Comments

@ssumpf
Copy link
Member

ssumpf commented May 7, 2024

We encountered this relocation type in the wild on x86_64 (R_X86_64_NONE) in Rust's pre-compiled standard library. Because supporting this type is easy it makes sense to add it for all architectures to the dynamic linker.
@ssumpf ssumpf added the feature label May 7, 2024
ssumpf added a commit to ssumpf/genode that referenced this issue May 7, 2024
@ssumpf
ldso: add support for R_<arch>_NONE relocations
066c292 
We discovered this relocation, which does nothing, in pre-compiled
libraries. It is easy to implement because it has the same
relocation-type number (0) for all supported ABIs.

Also adjust error message from "Unsupported PLT relocation" to
"Unsupported translation table address format" to not confuse the
relocation type with the translation table type.

fixes genodelabs#5209
@ssumpf ssumpf added the fixed label May 7, 2024
chelmuth pushed a commit that referenced this issue May 8, 2024
@ssumpf @chelmuth
ldso: add support for R_<arch>_NONE relocations
6c9d332 
We discovered this relocation, which does nothing, in pre-compiled
libraries. It is easy to implement because it has the same
relocation-type number (0) for all supported ABIs.

Also adjust error message from "Unsupported PLT relocation" to
"Unsupported translation table address format" to not confuse the
relocation type with the translation table type.

Fixes #5209
@chelmuth
Copy link
Member

chelmuth commented May 8, 2024

Merged to staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chelmuth @ssumpf