Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CRITICAL Invalid_argument("rseek_in") when query invalid forum msg #1788

Open
michelmno opened this issue Apr 26, 2024 · 3 comments
Open

Comments

@michelmno
Copy link
Contributor

CRITICAL Invalid_argument("rseek_in") when query invalid forum msg id

  • gw built from geneweb/master branch (cid ebbbae1)

  • access forum, select one of existing message is good.

  • BUT, if manually change p value in url, then browser do not receive answer, and following error message reported in gwd.log
    http://localhost:2317/testbasefusionnee?m=FORUM&p=666
    [2024-04-26 08:46:51]: CRITICAL testbasefusionnee_w?m=FORUM&p=666 Invalid_argument("rseek_in")

  • I would suggest to not log CRITICAL error, but to report incorrect input page to user; as This is not a gwd or database critical failure.

  • Alternative problem: if "plugins=forum" is not set in gwf
    then Forum button still present in Welcome page
    BUT pushing it is reporting an invalid request page
    Capture d’écran du 2024-04-26 09-15-11
    Note that this specific failure only exist with local acccess (localhost:2317) but not with cgi access !

  • Is it normal to have Forum button on Welcome page if "plugins=forum" is not set in gwf

hgouraud added a commit to hgouraud/geneweb that referenced this issue Apr 26, 2024
@michelmno
Copy link
Contributor Author

testing with last hgouraud/fix-home cid 6c09bf1

  • confirm no more Forum button if gwf do not have "plugins=forum"
    and correctly displayed if added in gwf.

  • if "plugins=forum" not set gwf then I have expected incorrect request page if
    http://localhost:2317/testbasefusionnee?m=FORUM

  • BUT still able to access forum in cgi mode !
    http://localhost/cgi-bin/gwtst?b=testbasefusionnee&m=FORUM

  • and finally still has CRITICAL error in gwd log, if user try to access an invalid message id.

@hgouraud
Copy link
Collaborator

new error messages (instead of error # 10) will mention that m=FORUM is not available in this context.

@michelmno
Copy link
Contributor Author

new error messages (instead of error # 10) will mention that m=FORUM is not available in this context.

tested OK

@michelmno michelmno mentioned this issue Apr 28, 2024
hgouraud added a commit to hgouraud/geneweb that referenced this issue Apr 29, 2024
a2line pushed a commit to hgouraud/geneweb that referenced this issue Apr 30, 2024
hgouraud added a commit to hgouraud/geneweb that referenced this issue May 1, 2024
hgouraud added a commit to hgouraud/geneweb that referenced this issue May 1, 2024
hgouraud added a commit to hgouraud/geneweb that referenced this issue May 1, 2024
a2line pushed a commit to a2line/geneweb that referenced this issue May 9, 2024
a2line pushed a commit to a2line/geneweb that referenced this issue May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants