Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unbound var "rng" in second relation page and incomplete title #1782

Open
michelmno opened this issue Apr 19, 2024 · 11 comments
Open

[BUG] Unbound var "rng" in second relation page and incomplete title #1782

michelmno opened this issue Apr 19, 2024 · 11 comments

Comments

@michelmno
Copy link
Contributor

Unbound var "rng" in second relation page and incomplete title

Use Case

  • from individual page, look for short path relation with a second individual (image 1)
  • first reported page has missing second individual first & last names
    despite correct display of their relation. (image 2)
    http://localhost:2317/testbasefusionnee?pz=michel&nz=normand&ocz=0&em=R&ep=henri&en=normand&m=NG&select=input&n=&fn=claire&sn=garnesson&et=S
  • depress top left button to display next path
    now only the two individual names are displayed (image 3) but
    ** no relation information.
    ** bug icon reports errors and
    ** gwd log reports unbound var "rng" failure
    http://localhost:2317/testbasefusionnee?pz=michel&nz=normand&em=R&ei=62&i=5731&et=S&ef0=1604
  • if same button is depressed, then go back to first valid relation view, and now title has 2nd individual name (image 4)
    http://localhost:2317/testbasefusionnee?pz=michel&nz=normand&&em=R&et=S&i=5731&ei=62
  • test done on last master branch cid 2ab85d8 tag: v7.1-beta
  • same failures with hgouraud/fix_home cid 55bfdbe

Capture d’écran du 2024-04-19 04-49-13
Capture d’écran du 2024-04-19 04-50-11
Capture d’écran du 2024-04-19 04-45-27

extract gwd log:
*** <W> template file, characters 1459-1462:
Failed - unbound var "rng"
*** <W> template file, characters 1592-1595:
Failed - unbound var "rng"

Capture d’écran du 2024-04-19 05-03-15

Paramètres de configuration
testbasefusionnee.gwf
default_sosa_ref=michel.0 normand
has_events=always
hide_private_names=yes
no_image_for_visitor=yes
perso_module_a=arbres
perso_module_c=chronologie
perso_module_d=data_3col
perso_module_f=fratrie
perso_module_g=gr_parents
perso_module_h=htrees
perso_module_i=individu
perso_module_l=ligne
perso_module_n=notes
perso_module_p=parents
perso_module_r=relations
perso_module_s=sources
perso_module_u=unions
private_years=100
propose_titles=no
short_place_threshold=5000
static_path=/gw/etc/
use_restrict=yes
@hgouraud
Copy link
Collaborator

L'origine des erreurs rng et random est claire. La solution adoptée dans fix-home n'est pas applicable partout (pages "non trouvé" par exemple) et ces erreurs persisteront!

@michelmno
Copy link
Contributor Author

Test done with last updates of hgouraud/fix-home (cid 65c5e18)

  • There is no more unbound var "rng" in gwd.log for above scenario.
  • But, still have incomplete Title (missing second individual first & last names) same as image2
  • And no relation information same as image3

Do I have to create other issue, or should we continue with that one to track those two remaining problems ?

@hgouraud
Copy link
Collaborator

Keep this issue open

hgouraud added a commit to hgouraud/geneweb that referenced this issue Apr 26, 2024
@hgouraud
Copy link
Collaborator

my last commit on fix-home should address the incomplete title issue. Thanks for testing.

hgouraud added a commit to hgouraud/geneweb that referenced this issue Apr 26, 2024
@michelmno
Copy link
Contributor Author

my last commit on fix-home should address the incomplete title issue. Thanks for testing.

  • I tested with last hgouraud/fix-home at cid 6c09bf1,
    and still same problem of title:
    "Chemin entre Henri Normand et" while expecting
    "Chemin entre Henri Normand et Claire Garnesson"
    Just in case that could help I am adding the generated source files associated to image2 and image4
    incomplete_h3.zip

@hgouraud
Copy link
Collaborator

can you provide the complete URL for this case. thnx

hgouraud added a commit to hgouraud/geneweb that referenced this issue Apr 27, 2024
@hgouraud
Copy link
Collaborator

I think I fixed the problem.
6c09bf1..c4fce82 fix-home -> fix-home
note the different URL according to method of capture of the target person:
1/ first_name surname in the "public name" input line -> n=first_name+surname&fn=&sn=
2/ first_name and surname in two separate input lines -> n=&fn=first_name&sn=surname

I tend to use systematically the first input method!

hgouraud added a commit to hgouraud/geneweb that referenced this issue Apr 27, 2024
@hgouraud
Copy link
Collaborator

A last comment: the name displayed is based on the data available in the URL. If no accents are provided, they wont be restored. And particles are not properly handled!
Correcting those two problems requires access to the base which is not available in the execution context of this piece of template. I will explore solutions.

@michelmno
Copy link
Contributor Author

A last comment: the name displayed is based on the data available in the URL. If no accents are provided, they wont be restored. And particles are not properly handled! Correcting those two problems requires access to the base which is not available in the execution context of this piece of template. I will explore solutions.

About that, I assume that this is the same cause for query below (identified while using run_GW_test.sh)
The descendant title has missing first name and name while using id in url, while no problem while using p & n evars.
Capture d’écran du 2024-04-28 08-01-00
Capture d’écran du 2024-04-28 08-01-17

Do I keep in this issue ? or should I create another one ?

@hgouraud
Copy link
Collaborator

yes most likely.
keep the issue.
in the future, make sure the url is visible, or provide a copy
thanks

@michelmno
Copy link
Contributor Author

michelmno commented Apr 28, 2024

in the future, make sure the url is visible, or provide a copy

I will do next time, in that case url in images

hgouraud added a commit to hgouraud/geneweb that referenced this issue Apr 29, 2024
a2line pushed a commit to hgouraud/geneweb that referenced this issue Apr 30, 2024
hgouraud added a commit to hgouraud/geneweb that referenced this issue May 1, 2024
hgouraud added a commit to hgouraud/geneweb that referenced this issue May 1, 2024
hgouraud added a commit to hgouraud/geneweb that referenced this issue May 1, 2024
a2line pushed a commit to a2line/geneweb that referenced this issue May 9, 2024
a2line pushed a commit to a2line/geneweb that referenced this issue May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants