Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] small translation flaw: t1 GET param not converted #1698

Open
ftrojahn opened this issue Jan 24, 2024 · 2 comments
Open

[BUG] small translation flaw: t1 GET param not converted #1698

ftrojahn opened this issue Jan 24, 2024 · 2 comments

Comments

@ftrojahn
Copy link

ftrojahn commented Jan 24, 2024

While doing the translations in https://github.com/ftrojahn/geneweb/tree/lex-de2/hd/lang I came upon
this small problem, which is only in German, yet.

Starting from e.g. https://geneweb7.trojahn.de/trojahn?m=C&i=86&lang=fr&v=11&lexcheck=1
regarding e.g. [cousins.9.2] I need in German the term de: Ur<sup>(x5)</sup>-Großtanten&#47; -onkel 2. Grades

If we click in French view on 6×-arrière-grands-cousins, then on the left uppermost link, we come to

https://geneweb7.trojahn.de/trojahn?lang=fr&m=RLM&i1=86&i2=60&i1=86&i3=757&i1=86&i4=817&i1=86&i5=1095&t1=6%C3%97-arri%C3%A8re-grands-cousins
So you see here the &t1=6%C3%97-arri%C3%A8re-grands-cousins GET Parameter.

But in German this is not correctly converted:

https://geneweb7.trojahn.de/trojahn?lang=de&m=RLM&i1=86&i3=364&i1=86&i5=722&i1=86&i6=1095&i1=86&i2=347&i1=86&i4=589&t1=Ur%3Csup%3E(x4)%3C/sup%3E-Gro%C3%9Ftanten/%20-onkel%202.%20Grades

as the conversion of "<sup>..</sup>" is not done:

&t1=Ur%3Csup%3E(x4)%3C/sup%3E-Gro%C3%9Ftanten/%20-onkel%202.%20Grades

Expected behavior / Comportement attendu

The t1 GET parameter should be correctly given and the output shown.

Versions

geneweb master 024d8c4 + see my translation branch above

@ftrojahn
Copy link
Author

Here are some pictures:

Bildschirmfoto von 2024-01-24 08 17 59@2x

Bildschirmfoto von 2024-01-24 08 17 37@2x

@hgouraud I can give you access to my geneweb7 test DB if needed.

@a2line
Copy link
Collaborator

a2line commented Jan 24, 2024

Hi. This is a wip on last PR fallback integrating URI as dependancy to manage a better encoding of parameters in URLs (typically for the case you found of t= in graphs). Thanks for the care of details (exponents and urls !)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants