-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display of modified forms #880
Comments
I think this is driven by the information provided in your GPI file -- |
@pgaudet If I'm following and am guessing right about what's happening, the answer is "yes". |
The PRO information is NOT in your GPI file (https://www.pombase.org/data/annotations/Gene_ontology/pombase.gpi.gz ) the line for that ID (PR:000050512) is:
Howveer based on the PRO entry, it looks like you should put the PRO-Short-label: | EXACT in column 2 of your GPI: https://proconsortium.org/cgi-bin/entry_pro?id=PR%3A000050512&retrieve.x=11&retrieve.y=14 Is this possible? |
We can do that. This can get very confusing and isn't very meaningful to the users. Especially if there are many modified forms like rpb1 @kimrutherford can you look into getting these 2 labels into the GPI? |
AFAIK what is is column 2 of the GPI gets displayed, so you'd need to make sure the information you want is there. |
Great thanks. Are Complex Portal entities in Noctua read from the GPI file? We were discussing this morning and decided they probably were, but I have a note to check... |
@ValWood |
Hi @vanaukenk - So do we see these IDs in Noctua after the next GO update? or is this on a different cycle? |
@ValWood |
great! |
I can't locate a complex that is in our GPI file CPX-555 |
@ValWood how long ago did you add that to your file? If it does not show up after today's update, let's look into it. |
@ValWood I'm guessing that it was added during this last period. It now seems to be available: http://noctua-amigo.berkeleybop.org/amigo/term/ComplexPortal:CPX-555 . |
@ValWood Note that the maintenance outages happen from ~4-6pm PDT on the Thursdays when we have them. We put the outages on the GO calendar, too, (and send the email notice out), just in case you were unclear about the timing of the updates. Thx. |
ignore me, I get it, I will check on Friday. |
...It is Friday....... |
We had another look, we can find the complex when searching for entities in the activity unit, but not in the "protein complex" tool. MAybe we have something wrong in our GPI file? |
MAybe we used the incorrect term for "complex" and is defaulting to gene? (GPI v20 |
@ValWood - let me do some systematic testing/investigating to see if I can understand why it's not showing up in the Protein Complex Form part of the VPE. I'll probably also move this issue to a separate ticket in the VPE tracker, but will link it here. |
@ValWood - this does indeed seem to be an issue with how the S. pombe protein-containing complexes are being typed in Noctua, although you've used the correct type (GO:0032991) for the gpi2.0 file format. Looking at the entries for an S. pombe vs S. cerevisiae protein-containing complex in noctua-amigo I see the parentage differences: The difference between the S. pombe and S. cerevisiae gpi files is the format; SGD is still using gpi1.2. @kltm @balhoff - could the incorrect typing of S. pombe complexes in NEO be the result of a different input file format? |
not that this isn't critical for us right now if you are busy, we can manage without complexes in the short term but we want to keep moving with this it so we can power through later. |
@ValWood - can you still make the annotations to complexes that you need using the gene product field in the Activity Unit interface? Let me know if you want to conference. |
The logic for GPI seems to be:
The same is mostly true in the GAF processor, except the |
@kltm - so, if a group's input file is gpi2.0 and they're using GO:0032991 for protein-containing complex type, does this mean the type field is ignored and everything defaults to 'information biomacromolecule'? |
@vanaukenk Well, assuming there are no bugs elsewhere, the logic is basically to pull the "type" info from a column in the line and match as outlined above. I'm not quite sure what you mean by "using GO:0032991". If you want to hop on a Zoom, we can sort this out real quick. |
In discussion with @vanaukenk we have modified the parser to follow the GPI 2.0 spec a little better. Re-running load to see if there are improvements. |
@ValWood |
Yes that works, thanks! |
In this model
The phosphorylation status of rec8 is important (in this case (Phos:(S450),UnPhos(S412))
In PRO this has a short label
PRO-Short-label: EXACT: Spom-rec8/Phos:2
Because most of our models will likey have modified forms and often multiple different modified forms (i.e acting as regulatory switches with different outcomes), I wonder if it would be possible to display the
"Phos:2" part of the PRO label on the noctua entity (currently only displays rec8 Spom whichever form is selected).
This will help us to navigate the different forms in the model.
I was really impressed that I could select and use modified forms!
The text was updated successfully, but these errors were encountered: