Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italics in model names appearing as tags on landing page, browser tab title #853

Open
suzialeksander opened this issue Nov 30, 2023 · 3 comments
Labels

Comments

@suzialeksander
Copy link

example: gomodel:YeastPathways_PWY-2301

The imported model name is "myo-inositol biosynthesis - imported from: Saccharomyces Genome Database" but the <i> and </i> tags remain on the GE browser tab title (FF) as well as the title listing on the Noctua landing page
Screenshot 2023-11-30 at 12 07 51

Name appears as intended in other places

Screenshot 2023-11-30 at 12 09 14

@tmushayahama

@kltm
Copy link
Member

kltm commented Nov 30, 2023

I think it might be worthwhile to bring this up in a larger context, especially given the recent AGR discussion of the same (thinking yesterday's A-Team call about the same topic). The fact that it works in AmiGO, in this case, is possibly more due to laziness than intent (although it has been a while).

It strikes me as odd that HTML is the "universal" language of making label typesetting (which I assume has its root in paper publication). Is this generally true? Do curators, looking at a file, feel fine about seeing HTML marks for superscript and italic? I would naively assume that ASCII w/o markup would be the preferred base, but I don't know the history here...

@kltm kltm added the question label Nov 30, 2023
@suzialeksander
Copy link
Author

Personally I'd prefer the text to be readable without tags, but I think we are not shocked when databases fail to handle "special characters". Even in papers appearing on the publisher's website it's not uncommon to have to read through HTML in one way or another.

I thought this was a small issue but worth a ticket in case there are other bulk imports, but if there's a bigger story here yes it might be great to bring up somewhere else.

@kltm
Copy link
Member

kltm commented Nov 30, 2023

I would agree that this, here, is likely an easy fix (just releasing some encoding or stripping tags). We can keep kicking the can down the road on the "bigger" conversation here no problem. That said, I would like to pick this up at some point in the future and figure out what our expectations are for display of names and how they should be output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants