-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotation filter GO class (direct) not working #718
Comments
Confirmed. I think there is something in the strings that are causing issues - I thought at first parentheses, but the ones under here work: https://amigo.geneontology.org/amigo/term/GO:0016671 But some like very odd... |
oh, interesting. This is the solr query: Notice that |
I talked a little with @pkalita-lbl about proximate places to look for the issue. While adding a fix (encoding/decoding), there may also be consequences in the UI filters and bookmarking, in addition to the "main" issue of the query to the Solr server. There are some oddities that have slipped into the code over the years in response to years of LBL testing (e.g. https://github.com/geneontology/amigo/issues?q=is%3Aissue+XSS+is%3Aclosed); the bug may be a consequence of that (or just a regular "oops" on my part). Either way, a fix should be XSS-safe. The problem code is probably in the |
The JS code is old, baroque, and quirky (ooo-- |
To reproduce:
https://amigo.geneontology.org/amigo/term/GO:0008746
click on GO class (direct) shows Total annotations: 103
(89) NAD(P)+ transhydrogenase activity
(9) NAD(P)+ transhydrogenase (AB-specific) activity
(5) NAD(P)+ transhydrogenase (B-specific) activity
click on any line shows Total annotations: 0
The text was updated successfully, but these errors were encountered: