Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Effort vs accomplishment" detector should flag "accomplishment" words with positive valence #64

Open
ProfJanetDavis opened this issue Jun 19, 2020 · 3 comments
Assignees
Labels
code enhancement New feature or request

Comments

@ProfJanetDavis
Copy link
Contributor

ProfJanetDavis commented Jun 19, 2020

@molliem and I discussed this on Slack. We are concerned that the Accomplishment words will clutter up the text-based report from the command-line tool. But they are necessary for visually explaining the computed ratio of Effort:Accomplishment words in the web interface.

The new effort-accomplishment detector is flagging a positive bias on accomplishments words. Is the old one? Depends on #82.

@j6k4m8
Copy link
Member

j6k4m8 commented Jul 28, 2020

I think this is fixed, as of #73:

image

I think our detector paradigm needs some help (since not all of them fit smoothly into 'attributable' parts of speech), but that's for another Issue.

@ProfJanetDavis
Copy link
Contributor Author

Thanks, @j6k4m8 ! I agree. We'll double check as part of addressing #82, and close this issue if appropriate.

@j6k4m8
Copy link
Member

j6k4m8 commented Nov 11, 2020

Fixed in #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants