arch-x86: Movfp account for dataSize=4 #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I97e7a6f2738a57cad9907ddfe5c8030a26c147e8
powerjg
reviewed
Apr 15, 2024
There was a problem hiding this comment.
Other than a small thing below, it looks good to me. Using functions like bits instead of manual bit-twiddling is less likely to produce errors in my experience.
Also, I assume you used the test code in #893, but it would be good to explicitly say so in the PR or the commit message.
Thanks for the contribution!
Change-Id: I577ee55752f917e561e4c741ba7a19f0229318b5
BobbyRBruce
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Movfp instruction did not account for only copying the lower half of src register if dataSize is 4.
GitHub Issue: #893
I used the test code in issue #893 to verify the fix is working.