Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW: Added github git source #45

Closed
wants to merge 1 commit into from
Closed

NEW: Added github git source #45

wants to merge 1 commit into from

Conversation

venarius
Copy link
Contributor

@venarius venarius commented Apr 25, 2019 •
edited

This adds GitHub as a standard available git source.

Resolves: #34

Also, this test currently directly hits GitHub. Maybe we should stub the request, but I don't know how easy that is going to be. Any thoughts?

@matthewd
Copy link
Member

For compatibility, it would probably need to use the same URL format as Old Bundler in the lockfile, but should automatically use https internally.

this test currently directly hits GitHub

Tests should not hit the network, so yes we'll need to find a way around that.

It looks like this supports github: "x/y" but not github: "x". If we're trying to improve backward-compatibility, I think it's important to support both forms that Bundler previously did.

Base automatically changed from master to main January 16, 2021 11:41
@venarius venarius closed this Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gel to support GitHub flag
2 participants
@venarius @matthewd