Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removing standard custom encoders and decoders #264

Open
DarkVoyage opened this issue Feb 21, 2023 · 4 comments
Open

Fix removing standard custom encoders and decoders #264

DarkVoyage opened this issue Feb 21, 2023 · 4 comments

Comments

@DarkVoyage
Copy link

According to changelog this was fixed in 2.2.3. I've tried removing them again and they reappear again.
I've already configured needed external encoders and decoders and want to remove these "examples".
image

@c72578
Copy link
Collaborator

c72578 commented Feb 21, 2023

„Removing of manually added Encoders or Decoders“ has been fixed. See: #201

@c72578
Copy link
Collaborator

c72578 commented Feb 22, 2023

@DarkVoyage Thanks for your report.
The current behavior is unusual concerning deleting of predefined external Encoders or Decoders.
Two possibilities:

  • Either gray out (disable) delete for predefined external Encoders or Decoders.
  • Or allow deleting of predefined external Encoders or Decoders and do not let them reappear.

@ha-korth
Copy link

ha-korth commented Feb 22, 2023

  • Or allow deleting of predefined external Encoders or Decoders and do not let them reappear.

They would reappear if the settings.txt file were ever deleted and a new default settings.txt file created.
To expand on the 'gray out' proposal. How about a setting to 'enable' external 'CommandLine' Encoders or Decoders?
Users have to supply the .exe to get these to work anyway so why not have them disabled by default and grayed-out in the GUI and advanced settings unless each external Encoder or Decoder is enabled?

{
= "$type": "CUETools.Codecs.CommandLine.EncoderSettings, CUETools.Codecs",
= "Name": "flac.exe",
= "Extension": "flac",
= "Enable": false, <<<<<<<<<<
= "Lossless": true,
= "SupportedModes": "0 1 2 3 4 5 6 7 8",
= "EncoderMode": "5",
= "Path": "flac.exe",
= "Parameters": "-%M -P %P - -o %O"
= },

@DarkVoyage
Copy link
Author

DarkVoyage commented Feb 22, 2023

I don't think it is a big problem to allow removing them completely. If user wants to restore them he can delete settings ini.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants