Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMD Plugin has an unnecessary warning #3157

Closed
GCHQDeveloper314 opened this issue Feb 7, 2024 · 0 comments · Fixed by #3217
Closed

PMD Plugin has an unnecessary warning #3157

GCHQDeveloper314 opened this issue Feb 7, 2024 · 0 comments · Fixed by #3217
Assignees
@GCHQDeveloper314
Labels
bug Confirmed or suspected bug good first issue Small, lower complexity and doesn't require pre-existing Gaffer knowledge
Milestone
v2.3.0

Comments

@GCHQDeveloper314
Copy link
Member

Describe the bug
When running the PMD plugin it shows the following warning:

[INFO] --- pmd:3.20.0:pmd (default-cli) @ cache ---
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO] PMD version: 6.53.0

To Reproduce
Steps to reproduce the behaviour:

  1. Run mvn pmd:pmd

Expected behaviour
No warning should be shown.

Additional context
This warning relates to cross-linking between PMD and the jxr plugin. PMD enables this by default, but Gaffer doesn't use jxr. Changing PMD config to disable this linking should remove the warning.
@GCHQDeveloper314 GCHQDeveloper314 added bug Confirmed or suspected bug good first issue Small, lower complexity and doesn't require pre-existing Gaffer knowledge labels Feb 7, 2024
@GCHQDeveloper314 GCHQDeveloper314 added this to the Backlog milestone Mar 15, 2024
@github-actions github-actions bot mentioned this issue May 20, 2024
Merged
@GCHQDeveloper314 GCHQDeveloper314 self-assigned this May 20, 2024
GCHQDeveloper314 added a commit that referenced this issue May 21, 2024
@GCHQDeveloper314
Merge branch 'develop' into gh-3157-PMD-plugin-unnecessary-warning
7e7f154
GCHQDeveloper314 added a commit that referenced this issue May 24, 2024
@GCHQDeveloper314
Gh-3157: Fix PMD plugin unnecessary warning (#3217)
9d2caa8 
* Disable jxr linking

* Upgrade version and enabled cache
Cache reduces the analysis time when running the plugin repeatedly

* Remove unnecessary cast
Issue detected by new PMD version

* Revert "Remove unnecessary cast"

This reverts commit 6c9697a.

* Rollback PMD plugin by one version
This avoids using the new version 7.0.0 of PMD which requires further fixes
@GCHQDeveloper314 GCHQDeveloper314 modified the milestones: Backlog, v2.3.0 May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GCHQDeveloper314 GCHQDeveloper314

Labels
bug Confirmed or suspected bug good first issue Small, lower complexity and doesn't require pre-existing Gaffer knowledge
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging a pull request may close this issue.

Gh-3157: Fix PMD plugin unnecessary warning gchq/Gaffer
1 participant
@GCHQDeveloper314