New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MapStore only supports string visibility #3121

Open

t92549 opened this issue Nov 27, 2023 · 0 comments

Labels

Milestone

Contributor

t92549 commented Nov 27, 2023 •

edited by GCHQDeveloper314

Describe the bug
The MapStore only supports visibility properties of type string. This is because of an incorrect assumption, from this cast:

Gaffer/store-implementation/map-store/src/main/java/uk/gov/gchq/gaffer/mapstore/impl/GetElementsUtil.java

Line 145 in 9d3f452

    
           final ElementVisibility elementVisibility = new ElementVisibility((String) e.getProperty(visibilityProperty));

Expected behaviour
Custom objects should be allowed as well as basic string visibilities.

Additional context
Right now the ApplyViewToElementsFunction uses the MapStore, so this is affecting federation.

t92549 added bug map-store labels

GCHQDeveloper314 added this to the Backlog milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment