Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FederatedOperation field payload exposed to modifications. #3085

Open
GCHQDev404 opened this issue Nov 14, 2023 · 1 comment
Open

FederatedOperation field payload exposed to modifications. #3085

GCHQDev404 opened this issue Nov 14, 2023 · 1 comment
Labels
bug Confirmed or suspected bug
Milestone

Comments

@GCHQDev404
Copy link
Contributor

GCHQDev404 commented Nov 14, 2023

Describe the bug
FederatedOperation now exposes internal field payload which can now be externally modified via getOperations() unlike the getPayload() operation

Expected behaviour
payload should not be able to be externally modified.

Additional context
since #3077
see

public Operation getPayloadOperation() {
return hasPayloadOperation() ? payloadOperation.shallowClone() : null;
}

@GCHQDev404 GCHQDev404 added the bug Confirmed or suspected bug label Nov 14, 2023
@GCHQDev404 GCHQDev404 changed the title FederatedOperation payload exposed to modifications. FederatedOperation field payload exposed to modifications. Nov 14, 2023
@t92549
Copy link
Contributor

t92549 commented Nov 14, 2023

Good catch, I missed this! Can probably be done as part of #3078

@GCHQDeveloper314 GCHQDeveloper314 added this to the Backlog milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed or suspected bug
Projects
None yet
Development

No branches or pull requests

3 participants