Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching/filtering doesn't show folded controls that match #20

Open
gcanyon opened this issue Jan 14, 2019 · 1 comment
Open

Searching/filtering doesn't show folded controls that match #20

gcanyon opened this issue Jan 14, 2019 · 1 comment

Comments

@gcanyon
Copy link
Owner

gcanyon commented Jan 14, 2019

Here's the behavior I'm seeing:

Case 1.

  1. Scrolled to the top of the list.
  2. Use the search box to filter the list.
  3. Select a control that in step 1 was not visible (below the bottom of the list).
  4. Clear the search bar.
  5. The control from step 3 is still highlighted and the list is scrolled so that it is visible.

Case 2.

  1. A group is folded.
  2. Use the search box to filter the list. The search will hit for some items in the folded group, but not the group.
  3. The group does not appear in the results -- this seems correct to me.
  4. The items in the group that match do not appear in the results -- this seems like a bug.

Case 3.

  1. A group is folded.
  2. Use the search box to filter the list. The search will hit for the group, and for some items in the folded group, but not all.
  3. The group appears in the results -- this seems correct to me.
  4. The folded item count will reflect all controls in the group, not the ones that match -- this seems like a bug.

The question of whether to automatically un-fold groups because controls in them match the search is unresolved in my mind, but I lean toward ditching folding when searching. As you say, though, merely ignoring folding while searching would mean that selecting a control and then clearing the search would re-hide the control in the fold. Bookmarking the control seems like a poor solution to this. Iteratively clearing folding to guarantee that highlighted controls will display when the search is cleared would actually be fairly easy, but would it make sense to do it? It seems like a pretty obscure method, if this is the behavior:

Case 4.

  1. Two groups are folded.
  2. Use the search box to filter the list. The search will hit for one item in each folded group, but not the groups.
  3. The two items appear in the results, but not the groups -- this seems correct to me.
  4. The user highlights one of the items in the results (but not the other).
  5. Clear the search bar.
  6. The group containing the highlighted item is unfolded, and the item is still highlighted. But the group containing the un-highlighted item is still folded, and that item is not visible or highlighted. -- this seems correct, but a bit wonky.
@slylabs13
Copy link

Case 1 good to go.

Case 2 I would not call abug. More like an oversight that never got addressed when folding as implemented.

Case 3 That the hits don't appear is certainly an issue. I think that when searching, unfolding everything is a good idea, because then I could at least interact with the object hit upon. Clearing the search field should probably re-fold the way it was before the search then. That is what a user would expect. The golden rule is don't change anything in the UI the end user doesn't want or expect.

Case 4 is irrelevant if case 3 (unfolding everything) is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants