Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface of normal distribution - notice about convention #32

Open
gustawdaniel opened this issue Jan 18, 2019 · 0 comments
Open

Interface of normal distribution - notice about convention #32

gustawdaniel opened this issue Jan 18, 2019 · 0 comments

Comments

@gustawdaniel
Copy link
Contributor

In this package Normal distribution have two parameters: mean and variance. But in many mathematical programs there is mean and standard derivation used. Examples:

  • Matlab

https://www.mathworks.com/help/stats/prob.normaldistribution.html

Parameters: mu, sigma

  • Mathematica

https://reference.wolfram.com/language/ref/NormalDistribution.html

Parameters: [μ,σ]

  • R

https://www.tutorialspoint.com/r/r_normal_distribution.htm

Parameters [x, mean, sd]


What we should do now? It is breaking change, so I propose to not change nothing now in this package but:

  • change interface of Normal from (mean, variance) to (mean, sigma) in next major breaking release and type it in migration documentation
  • now describe it in more visible manner. Because of In my opinion it is default approach that Normal dist should have (mean, sigma) as parameters and it should be marked more bold.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant