Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when fitting EAZY photoz with NIRISS data #215

Closed
TheSkyentist opened this issue Mar 4, 2024 · 0 comments
Closed

Bug when fitting EAZY photoz with NIRISS data #215

TheSkyentist opened this issue Mar 4, 2024 · 0 comments

Comments

@TheSkyentist
Copy link
Contributor

TheSkyentist commented Mar 4, 2024

When attempting to prepare for redshift fitting with grizli, I run auto_script.generate_fit_params with the include_photometry flag set to True. This causes an error when the code attempts to run eazy.photoz.PhotoZ:

self = eazy.photoz.PhotoZ(param_file=None, translate_file='zphot.translate', zeropoint_file=zpfile, params=params, load_prior=True, load_products=load_products)

The following error is retrieved:

ValueError: No valid filters found in [root]_phot_apcorr.fits!  Check that all flux and uncertainty columns are specified / translated correctly.

This is because NIRISS filters have an additional N aggregated onto the names (known to cause problems elsewhere, see #191).
The translation list will need to be updated with the additional N aggregated onto the filter names:

FILTER_TRANS = {'f098m': 201, 'f105w': 202, 'f110w': 241, 'f125w': 203, 'f140w': 204, 'f160w': 205, 'f435w': 233, 'f475w': 234, 'f555w': 235, 'f606w': 236, 'f625w': 237, 'f775w': 238, 'f814w': 239, 'f850lp': 240, 'f702w': 15, 'f600lpu': 243, 'f225wu': 207, 'f275wu': 208, 'f336wu': 209, 'f350lpu': 339, 'f438wu': 211, 'f475wu': 212, 'f475xu': 242, 'f555wu': 213, 'f606wu': 214, 'f625wu': 215, 'f775wu': 216, 'f814wu': 217, 'f390wu': 210, 'ch1': 18, 'ch2': 19, 'f336w':209, 'f350lp':339, 'f115w': 309, 'f150w': 310, 'f200w': 311}

In addition, "-CLEAR" is not properly stripped from filter names when making the combined catalog, causing further issues. I will issue a PR to fix both of these issues.

@TheSkyentist TheSkyentist changed the title Bug when fitting EAZY photoz Bug when fitting EAZY photoz with NIRISS data Mar 4, 2024
@gbrammer gbrammer closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants