Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: tox #67

Open
niconoe opened this issue May 26, 2020 · 3 comments
Open

Testing: tox #67

niconoe opened this issue May 26, 2020 · 3 comments
Assignees
@niconoe

Comments

@niconoe
Copy link
Contributor

niconoe commented May 26, 2020

I noticed that it seems tox testing has been added a long time ago via: #20, a nice addition IMHO.

Is it still in use? If no, I suggest some cleanup (tox.ini for example). If yes, I think we could make some improvements:

  • Document tox's use in contributor's documentation
  • Make sure tox environments (configured in tox.ini match the supported Python version - it's currently 2.7 and 3.4)
  • See if can combine tox and Travic-CI: the aim would be to have a single configuration point, and allow testing all environments both locally and on Travis-CI.

Hope this helps!
@sckott
Copy link
Collaborator

sckott commented May 26, 2020

I haven't been using tox myself. I run tests with make test, using nose.

I'd be happy to try tox, can you propose changes to the file?

@niconoe
Copy link
Contributor Author

niconoe commented May 28, 2020

Yeah, I'd be happy to contribute that! Don't hesitate to assign me to this issue (I can't do it myself) so there's some hope I don't forget about it :)

@sckott
Copy link
Collaborator

sckott commented May 28, 2020

I've assigned you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niconoe niconoe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niconoe @sckott