Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit useful scripts here! #479

Closed
ISSOtm opened this issue Jan 26, 2020 · 5 comments
Closed

Submit useful scripts here! #479

ISSOtm opened this issue Jan 26, 2020 · 5 comments
Labels
enhancement Typically new features; lesser priority than bugs meta This isn't related to the tools directly: repo organization, maintainership...

Comments

@ISSOtm
Copy link
Member

ISSOtm commented Jan 26, 2020

馃挕 Users can submit scripts they would like added to our contrib folder. The only requirement is that the script must be relevant to RGBDS, and useful to a large amount of our users. (Submit even if not sure, we're open to discussion!)


Would it be relevant and useful to provide (and/or distribute) this script with RGBDS? Could be useful to us at least to help debug the CI (when .bin files don't match).

@mid-kid
Copy link
Contributor

mid-kid commented Jan 26, 2020

Sounds like something that belongs in an extras/ or contrib/ directory, as it's a bit too specific compared to the general use of this assembler.

@ISSOtm
Copy link
Member Author

ISSOtm commented Jan 28, 2020

Thoughts, @AntonioND? New folder, separate repo, don't care at all?

@mid-kid
Copy link
Contributor

mid-kid commented Jan 28, 2020

If you start up a contrib/ directory I recommend looking for similar scripts you may be able to add. https://github.com/pret/pokecrystal/blob/master/tools/free_space.awk comes to mind, for example, but maybe there's other simple tools that fit the bill (maybe my unusedsymbols.py? It's a bit on the bigger side though).

Of course, being a contrib/ directory, it's not up to you to maintain such scripts, and you can drop them if they don't work anymore and nobody wants to fix them. It's more of an "interesting little scripts that might be useful to someone" thing. Nobody expects all of it to always work without modification. Kinda like awesome-gbdev in a way, except they probably don't want tiny rgbds-specific scripts.

@AntonioND
Copy link
Member

If it can be of some use for the CI, I guess it can be in the repository. And yeah, it would make to have another folder like contrib like @mid-kid says.

@ISSOtm
Copy link
Member Author

ISSOtm commented Jan 30, 2020

I added the script in b16ec83; as for adding other scripts, I would prefer if they had an explicit license before including them.

@ISSOtm ISSOtm changed the title Adding gbdiff script? Submissions for contrib folder Nov 3, 2020
@ISSOtm ISSOtm added the meta This isn't related to the tools directly: repo organization, maintainership... label Feb 10, 2021
@ISSOtm ISSOtm pinned this issue Feb 10, 2021
@ISSOtm ISSOtm changed the title Submissions for contrib folder Submit useful scripts here! Feb 10, 2021
@Rangi42 Rangi42 added the enhancement Typically new features; lesser priority than bugs label Mar 26, 2021
@ISSOtm ISSOtm closed this as completed Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Typically new features; lesser priority than bugs meta This isn't related to the tools directly: repo organization, maintainership...
Projects
None yet
Development

No branches or pull requests

4 participants