Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruction timings are listed in "clock cycles" — should they be named T-states? #500

Open
aaaaaa123456789 opened this issue Aug 7, 2023 · 2 comments
Labels
content Improvements or additions to documentation enhancement New feature or request

Comments

@aaaaaa123456789
Copy link
Member

The instruction table's header names the column listing the execution time for each instruction "clock cycles". This is an ambiguous term, as it could mean M or T cycles. While there is a description at the top, the term remains confusing, particularly for someone looking at the documentation quickly; it is also at odds with most community usage, where "cycles" means M-cycles.

Would it be better to label the column "T-states" explicitly instead? Another option would be to quarter the values, but I assume this wasn't done for some reason I'm unaware of.

@ISSOtm
Copy link
Member

ISSOtm commented Aug 8, 2023

I'd vote for "clocks", since it seems rather well understood that "clocks" are 4 MiHz, but "cycles" are 1 MiHz. Of course, restating both equivalences is a must.

@aaaaaa123456789
Copy link
Member Author

While it's not the first time I hear of that convention, I've never heard it from anyone but you. Are you sure it's as well understood as you say?

@avivace avivace added content Improvements or additions to documentation enhancement New feature or request labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants