Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work at all for me #31

Open
BarbzYHOOL opened this issue Oct 15, 2023 · 6 comments
Open

Doesn't work at all for me #31

BarbzYHOOL opened this issue Oct 15, 2023 · 6 comments
Labels
question Further information is requested

Comments

@BarbzYHOOL
Copy link

BarbzYHOOL commented Oct 15, 2023

I don't know how to make it work, I type an expanded form of an abbreviation I have already added or I just add a new abbr and type its expanded form and I see no tips

I read the readme and it said "just install and use as normal"

https://asciinema.org/a/I2mNHkzCJDwONf11EtxOivMd9 (first time i use asciinema sorry, the second command should have a tip, I prove it afterwards)

@BarbzYHOOL BarbzYHOOL added the question Further information is requested label Oct 15, 2023
@linduxed
Copy link

linduxed commented Dec 13, 2023

Same situation for me.

EDIT: I should say that the only time it seems to work for me is for "aliases" (i.e. functions) but for abbreviations is seems like it's not working (as stated by @BarbzYHOOL).

@BarbzYHOOL
Copy link
Author

I'm a sad sad panda :'( @gazorby

@tutods
Copy link

tutods commented Jan 17, 2024

Same for me
It's necessary to do anything to work with Oh My Fish?

@gazorby
Copy link
Owner

gazorby commented Jan 26, 2024

Hi!

I don't have much time to work on this plugin atm, but I will get back to it as soon as possible ;)

@rwietter
Copy link

I was facing this issue as well. I noticed that __ABBR_TIPS_KEYS and __ABBR_TIPS_VALUES are not updated every time Fish is opened. Therefore, if you add an abbr -a name command in the config.fish, it won't be recognized immediately.

I managed to resolve this by adding the following function that executes the script __abbr_tips_init every time Fish is opened. This will update __ABBR_TIPS_KEYS and __ABBR_TIPS_VALUES. It's not the most performant solution, but it works for now.

abbr --add gds 'git diff --stat'

function abbr_update_keys_and_values
    __abbr_tips_init
end

abbr_update_keys_and_values

My fish config

Related #17

@krestaino
Copy link

I just moved over to Fish from ZSH and wasn't aware of abbreviations until I stumbled across this plugin. The aliases worked fine and showed the tips when I used the long command, but once I switched them all to abbreviations, this plugin was not showing the tips for the abbreviations when using the long command. Based on @rwietter's comment and #17, I've found one option is to simply reinstall this plugin after adding new abbreviations. Then the tips will show up again when running the long commands. Considering I rarely add new aliases, or now abbreviations, this option is sufficient for me in the meantime and probably better than running __abbr_tips_init every new Fish instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

6 participants