Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove recoverylog FSM properties #265

Open
jgraettinger opened this issue Jun 4, 2020 · 0 comments
Open

remove recoverylog FSM properties #265

jgraettinger opened this issue Jun 4, 2020 · 0 comments

Comments

@jgraettinger
Copy link
Contributor

jgraettinger commented Jun 4, 2020

"Properties" were originally added to the log FSM when it was a concern that files like IDENTITY, written by RocksDB on DB initialization and never changed, would prevent normal RocksDB compaction action from shifting forward the offset "horizon" of recovery-log content that's still required.

These days it's totally vestigial, since un-needed portions of the recovery log are happily pruned from the middle of the log, and there's no downside to having a jumble of very old fragments, new fragments, and "islands" of still-used fragments in between.

It also causes some rare initialization failures, because the FSM requires that a property like IDENTITY is never written again once initialized, and it turns out there are certain conditions where RocksDB will actually write this file again.

We should remove support for recording new Properties updates, while keeping required support to not break Properties that already exist in FSM hints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant