Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print a more descriptive / friendly msg when a render pass is unavailable #837

Open
iche033 opened this issue Mar 23, 2023 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@iche033
Copy link
Contributor

iche033 commented Mar 23, 2023

When a render pass is not registered / unavailable, the render pass system currently prints out an msg with the typeid name of the render pass. ,e.g.

RenderPass of typeid 'N2gz9rendering2v714DistortionPassE' is not registered

This looks more alarming than necessary. Consider printing out a more friendly name than typeid

Desired behavior

For the above example, it would be better to just say something like Distortion Pass is not supported for that particular render engine.

Implementation suggestion

Consider changing the macro to store a name other than typeid (which is what gets printed). This breaks current behavior so would need to go into main

Additional context

Related: #830 (comment)

@iche033 iche033 added the enhancement New feature or request label Mar 23, 2023
@osrf-triage osrf-triage added this to Inbox in Core development Mar 23, 2023
@iche033 iche033 changed the title Print a more friendly msg when a render pass is unavailable Print a more descriptive / friendly msg when a render pass is unavailable Mar 23, 2023
@azeey azeey moved this from Inbox to To do in Core development Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

1 participant