Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No violation for Dictionary, Enumeration, and Stack #182

Open
delanym opened this issue Apr 1, 2023 · 5 comments
Open

No violation for Dictionary, Enumeration, and Stack #182

delanym opened this issue Apr 1, 2023 · 5 comments

Comments

@delanym
Copy link
Contributor

delanym commented Apr 1, 2023

Why is use of java.util.Stack not a violation, but java.util.Vector is?

@gaul
Copy link
Owner

gaul commented Apr 1, 2023

Seems like an oversight. Please investigate and submit a PR.

@delanym
Copy link
Contributor Author

delanym commented Apr 3, 2023

I've done Stack, but need to add Dictionary (Map) and Enumeration (Iterator).
Properties are also consider legacy API, but there's no suggested alternative (although there's the Preferences API)

@gaul
Copy link
Owner

gaul commented Apr 4, 2023

I think Dictionary and Enumeration would make good additions athough they are rarely used. I am not sure about Properties since I have never used Preferences but the former is baked into a lot of simple configuration uses, including S3Proxy.

@gaul gaul changed the title No violation for java.util.Stack No violation for Dictionary, Enumeration, and Stack Apr 4, 2023
@gaul
Copy link
Owner

gaul commented Feb 17, 2024

Dictionary and Enumeration are abstract classes so we would need to generate violations for subclasses. @delanym do you have a more specific feature request?

@delanym
Copy link
Contributor Author

delanym commented Feb 17, 2024

My interest in this is contingent on removing their usage from my own code, which is proving difficult at the moment. But I should get to it this year

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants