Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component hangs at loadingComponent after Jitsi update (meet.jit.si, alpha.jitsi.net and further recent deployments) #14

Open
OrestTa opened this issue Jul 9, 2020 · 14 comments

Comments

@OrestTa
Copy link

OrestTa commented Jul 9, 2020

It seems like an update rolled out to e.g. meet.jit.si in the last 12 hours broke the react-jitsi component. It never loads, keeping displaying the loadingComponent. No error or warning messages are logged to the console. It's fully functional again if I set the domain property to a less recent Jitsi deployment, e. g. 8x8.vc.

@OrestTa
Copy link
Author

OrestTa commented Jul 9, 2020

Update: This is due to the "Join Meeting" preparation page that's now displayed on meet.jit.si – it prevents the loaded flag to be set to true, so the API iframe is css-hidden and the loadingComponent is not removed from the DOM.

@e18r
Copy link

e18r commented Jul 9, 2020

@otrsk were you able to find a workaround? Is it possible to manually set the loaded flag to true?

@OrestTa
Copy link
Author

OrestTa commented Jul 9, 2020

@otrsk were you able to find a workaround? Is it possible to manually set the loaded flag to true?

@e18r You could edit the node_module directly to not show the loadingComponent at all and not hide the iframe during loading; however, note that this will result in a different behaviour: Jitsi will show a previously unseen "call preparation" page and only notify your app that it's ready once the user clicks through it. You could use another domain such as meet.8x8.vc as long as it hasn't deployed the new version / config as workaround.

@e18r
Copy link

e18r commented Jul 9, 2020

@otrsk thank you so much. I just temporarily fixed the bug in my app by switching to the domain meet.8x8.vc. It'll probably be good for a few days while I find a more definitive solution.

I'm gonna edit the node_module as you suggest in order not to depend on 8x8 upgrading to the latest version, which they could do very soon. However, I'd also like to understand this issue better and, why not, maybe even contribute a PR to this useful repo.

Do you have any idea where's the upstream code that is causing this? Looking at the commit history of Jitsi Meet doesn't seem to give any answers.

@OrestTa
Copy link
Author

OrestTa commented Jul 9, 2020

@e18r I've only had time for a quick glance at the code, unfortunately. However, I've seen the "call preparation" (not sure what the real name is) feature deployed at e.g. https://alpha.jitsi.net/ at least a few weeks ago already. So this might be a config change. I didn't find a flag to disable the "call preparation" feature in the iframe API, but the documentation seemed to be outdated, so you might have more luck looking at the code!

@dacopan
Copy link

dacopan commented Jul 9, 2020

@otrsk @e18r
seeing source code of jitsi you can set tis config prop prejoinPageEnabled to false

https://codesandbox.io/s/youthful-cache-z5g76?file=/src/App.js

@dacopan
Copy link

dacopan commented Jul 9, 2020

https://github.com/jitsi/jitsi-meet/blob/master/config.js#L311

@OrestTa
Copy link
Author

OrestTa commented Jul 9, 2020

@dacopan amazing, thanks! For Typescript, combined with adding prejoinPageEnabled?: boolean; to react-jitsi/dist/types.d.ts>ConfigOptions, everything seems to work like a charm! :)

@OrestTa
Copy link
Author

OrestTa commented Jul 9, 2020

@gatteo This option would need to always be set to false for the current loading logic to work as expected, so you might want NOT to expose it to the user.

@OrestTa
Copy link
Author

OrestTa commented Jul 9, 2020

PS: For Typescript, you can enforce the untyped flag this way without having to touch the node_module:
// @ts-ignore
prejoinPageEnabled: false,

@e18r
Copy link

e18r commented Jul 9, 2020

@dacopan mil gracias hermano!

@sumanyu-soniwal
Copy link

Thanks a lot @dacopan @otrsk

@N3zTho
Copy link
Contributor

N3zTho commented Aug 3, 2020

@dacopan @otrsk Great! 👏

@Kannndev
Copy link

Kannndev commented Sep 9, 2020

@gatteo Please include this in the readme file. It would help someone because at first even I thought the library is broken.

idimensionz added a commit to idimensionz/react-jitsi that referenced this issue Nov 25, 2020
This change should fix the issue gatteo#28 with the demo not starting. The fix was discussed in issue gatteo#14 but no PR was submitted for that issue.
jernejpregelj added a commit to jernejpregelj/react-jitsi that referenced this issue Feb 2, 2021
Solving missing type error as described in gatteo#14 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants