Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new /html functionality not clear #276

Closed
rossPatton opened this issue May 6, 2016 · 3 comments
Closed

new /html functionality not clear #276

rossPatton opened this issue May 6, 2016 · 3 comments

Comments

@rossPatton
Copy link
Contributor

So I upgrade and I get this message:

Gatsby is currently using the default template for HTML. You can override
this functionality by creating a React component at "/html.js"

You can see what this default template does by visiting:
https://github.com/gatsbyjs/gatsby/blob/master/lib/isomorphic/html.js

Already I am confused, because I have an html.jsx in my root directory and the previous version of gatsby picked it up fine. Maybe I need to put it somewhere else now with the new version?

So I end trying both /wrappers and /pages, neither of which work either
So then I try changing the extension to .js because I use .jsx, and that doesn't work either

Other than this 1 issue, upgrading to 0.10 was painless, but I need code that's in html.jsx, and it's not clear to me why this behavior would have changed?

These are the placements that I have tried:

/html.js
/wrappers/html.js
/pages/html.js

Is there something obvious I'm missing?

@patrykkopycinski
Copy link
Contributor

Hey @rossPatton, PR #275 should resolve this issue, please downgrade to 0.10.0 and try again

@rossPatton
Copy link
Contributor Author

hah! that was it. thanks for the quick response

@KyleAMathews
Copy link
Contributor

@rossPatton I just released 0.10.2 with the fix in #275. Would appreciate it if you could upgrade and tell me if the fix is working for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants