Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gatsby-dev-cli]: don't check for local package.json when configuring path to monorepo #11535

Closed
pieh opened this issue Feb 4, 2019 · 1 comment
Labels
good first issue Issue that doesn't require previous experience with Gatsby type: bug An issue or pull request relating to a bug in Gatsby

Comments

@pieh
Copy link
Contributor

pieh commented Feb 4, 2019

When setting path to monorepo with gatsby-dev-cli (gatsby-dev --set-path-to-repo /path/to/my/cloned/version/gatsby) we shouldn't check for local package.json. This is confusing when doing initial setup and for that step it's also not needed to check it because we don't use it.

Here's related code -

if (!havePackageJsonFile) {
console.error(`Current folder must have a package.json file!`)
process.exit()
}

It should be moved after pathToRepo handling

@pieh pieh added type: bug An issue or pull request relating to a bug in Gatsby good first issue Issue that doesn't require previous experience with Gatsby labels Feb 4, 2019
@amad-person
Copy link
Contributor

Would like to take this issue up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue that doesn't require previous experience with Gatsby type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

No branches or pull requests

2 participants