Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket: response time check #4544

Open
Amerousful opened this issue Mar 19, 2024 · 2 comments
Open

Websocket: response time check #4544

Amerousful opened this issue Mar 19, 2024 · 2 comments

Comments

@Amerousful
Copy link
Contributor

Hello.
I have a suggestion to add support to check the response time for the WebSocket.

Currently, there's only timeout logic which provides no details upon failure. I believe that having timeout and response time check will be more useful and provide a more comprehensive way to analyze failed checks. This approach would provide an upper bound with the timeout parameter, while also allowing for check failure based on excessive response times, thereby enabling more detailed logging and analysis.
Do it in the same way as for HTTP .check(responseTimeInMillis...)

val wsCheck = ws.checkTextMessage("checkName")
  .check(
      responseTimeInMillis.lte(10000)
  )

exec(ws("Send").sendText("hello")
  .await(30)(wsCheck))

How does sound this idea?

Thanks!

@slandelle
Copy link
Member

Actually, I'm really wondering if anyone uses the responseTimeInMillis check, even for HTTP.

@Amerousful
Copy link
Contributor Author

Hm... I use it, I find it quite handy for analyzing outliers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants