Why? And what about failures?

[LouisCAD]

https://github.com/gastsail/CocktailApp/blob/65f3a9c776cf096a5572c52cc502a38c106b1b1d/app/src/main/java/com/g/tragosapp/data/remote/NetworkDataSource.kt#L18-27

[gastsail]

Since is a suspend function, inside Resource.success you are callind the API which is another suspend function, any exceptions thrown by that call in the Resource.Success will propagate the error to the catch block in the viewmodel

[LouisCAD]

But why use callbackFlow, and why make it a Flow at all?

[LouisCAD]

And why wrap into Resource.Success if you don't wrap it in unsuccessful cases?

[gastsail]

The reason of using callbackFlow there is that in this repo

CocktailApp/app/src/main/java/com/g/tragosapp/domain/DefaultCocktailRepository.kt

Line 30 in 5506f6e

override suspend fun getCocktailByName(cocktailName: String): Flow<Resource<List<Cocktail>>> =

I don't want to return Livedata to emit cache data before the concrete call to the server which brings up the latest data.

About the failure, is beign handled in the viewmodel when that success operation returns an exception, it will be propagated to the viewmodel catch block of the calling function

[gastsail]

Any improvements in the code will be more than welcome @LouisCAD 💯