Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$docker::service_provider is not respected by docker::run #755

Open
optiz0r opened this issue Jul 1, 2018 · 1 comment
Open

$docker::service_provider is not respected by docker::run #755

optiz0r opened this issue Jul 1, 2018 · 1 comment

Comments

@optiz0r
Copy link

optiz0r commented Jul 1, 2018

docker::service_provider can be manually set to override the choice of service provider for the docker daemon itself, but containers created with docker::run do not respect this and use hardcoded defaults for particular operating systems. params.pp already does the work of figuring out whether the node is running systemd (which can be overridden when necessary).

I propose to add a single check to see if docker::service_provider is systemd, and if so set the necessary variables once (rather than again, duplicating those for each OS which does support systemd), and fall back to the OS-specific blocks for non-systemd OSes.

Corresponding pull request incoming.

@optiz0r
Copy link
Author

optiz0r commented Jul 1, 2018

I see I cannot actually use docker::service_provider without making significant changes to the way the code works because the defined type includes docker::params only and not the base docker class. Is this appropriate, or should the docker::run type just have a service_provider parameter which defaults to docker::params::service_provider if not set explicitly?

optiz0r added a commit to optiz0r/garethr-docker that referenced this issue Jul 1, 2018
Its possible to override the `service_provider` when managing the docker
daemon in case the defaults in params.pp aren't correct, but not when
defining a container using `docker::run`. This change adds a new
`service_provider` parameter to the run defined type, so that containers
can also be managed in these situations.

Fixes garethr#755
optiz0r added a commit to optiz0r/garethr-docker that referenced this issue Jul 2, 2018
Its possible to override the `service_provider` when managing the docker
daemon in case the defaults in params.pp aren't correct, but not when
defining a container using `docker::run`. This change adds a new
`service_provider` parameter to the run defined type, so that containers
can also be managed in these situations.

Fixes garethr#755
optiz0r added a commit to optiz0r/garethr-docker that referenced this issue Jul 2, 2018
Its possible to override the `service_provider` when managing the docker
daemon in case the defaults in params.pp aren't correct, but not when
defining a container using `docker::run`. This change adds a new
`service_provider` parameter to the run defined type, so that containers
can also be managed in these situations.

Fixes garethr#755
optiz0r added a commit to optiz0r/garethr-docker that referenced this issue Jul 2, 2018
Its possible to override the `service_provider` when managing the docker
daemon in case the defaults in params.pp aren't correct, but not when
defining a container using `docker::run`. This change adds a new
`service_provider` parameter to the run defined type, so that containers
can also be managed in these situations.

Fixes garethr#755
mudler added a commit to sabayon-puppet/garethr-docker that referenced this issue Aug 7, 2018
Its possible to override the `service_provider` when managing the docker
daemon in case the defaults in params.pp aren't correct, but not when
defining a container using `docker::run`. This change adds a new
`service_provider` parameter to the run defined type, so that containers
can also be managed in these situations.

Fixes garethr#755
cegeka-jenkins pushed a commit to cegeka/puppet-docker that referenced this issue Apr 17, 2024
Add syslog_facility parameter to docker::run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant